Fix : User Detail Responsiveness #10366

DonXavierdev · 2025-02-02T19:14:05Z

Proposed Changes

Fixes Mobile View UI : User detail responsiveness issue #10365
Add word breaks
Remove extra padding

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

Style
- Adjusted the responsive grid layout in the organization users view by shifting the column breakpoint, enhancing display consistency on larger screens.
- Added margin-left styling to the add user button for improved layout.
- Enhanced username display by allowing long text to break onto a new line.

coderabbitai · 2025-02-02T19:14:12Z

Walkthrough

The pull request modifies the layout of the FacilityOrganizationUsers component by changing the grid breakpoint for displaying two columns from medium (md) to large (lg). Additionally, it enhances the username display by allowing long usernames to break onto a new line. The AddUserSheet component is also updated to include a margin-left style on a button, improving its layout. No functional changes or logic modifications are introduced.

Changes

File	Change Summary
src/pages/Facility/.../FacilityOrganizationUsers.tsx	Updated grid layout breakpoint from `md:grid-cols-2` to `lg:grid-cols-2`; modified username `span` class to include `break-words`.
src/pages/Organization/.../AddUserSheet.tsx	Added `className="ml-3"` to the `Button` component in `SheetTrigger`.

Assessment against linked issues

Objective	Addressed	Explanation
Mobile View UI: User detail responsiveness issue (#10365)	✅

Possibly related PRs

Fix Online Status Indicator in Organization Tab #9728: The changes in the main PR are related to the modifications made in the FacilityOrganizationUsers component, specifically in the same file where the layout and display logic are adjusted, while the retrieved PR also alters the same component but focuses on user status representation.

Suggested labels

tested

Suggested reviewers

Jacobjeevan
rithviknishad

Poem

I'm just a bunny hopping by,
With grids aligned up high,
Changing breakpoints with a cheer,
Making screens more kind and clear,
A joyful dance in code so spry!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f158583 and 08b0418.

📒 Files selected for processing (2)

src/pages/Facility/settings/organizations/FacilityOrganizationUsers.tsx (2 hunks)
src/pages/Organization/components/AddUserSheet.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

src/pages/Organization/components/AddUserSheet.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

src/pages/Facility/settings/organizations/FacilityOrganizationUsers.tsx

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: cypress-run (1)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-02T19:14:24Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`08b0418`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67a0f6e51078a5000832741e
😎 Deploy Preview	https://deploy-preview-10366--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Users/UserListAndCard.tsx (1)
60-63: Fix className formatting issues.

The whitespace class is incomplete and should be whitespace-nowrap

Remove the trailing space in the className string
 <Badge
   variant="secondary"
-  className="bg-yellow-100 whitespace md:px-0 md:py-0 "
+  className="bg-yellow-100 whitespace-nowrap md:px-0 md:py-0"
 >

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d880c7 and cd890ef.

📒 Files selected for processing (2)

src/components/Users/UserListAndCard.tsx (1 hunks)
src/pages/Facility/settings/organizations/FacilityOrganizationUsers.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: cypress-run (1)

🔇 Additional comments (1)

src/pages/Facility/settings/organizations/FacilityOrganizationUsers.tsx (1)

118-118: LGTM! Good responsive design improvement.

Adding md:break-words class ensures long usernames wrap properly on medium screens, preventing layout issues.

Jacobjeevan · 2025-02-03T06:51:10Z

src/pages/Facility/settings/organizations/FacilityOrganizationUsers.tsx

@@ -115,7 +115,7 @@ export default function FacilityOrganizationUsers({ id, facilityId }: Props) {
                            {userRole.user.first_name} {userRole.user.last_name}
                          </h1>
                          <span className="text-sm text-gray-500">
-                            <span className="mr-2">
+                            <span className="mr-2 md:break-words">


Let's modify the grid for card container, so that we switch to 2 containers for lg, rather than md.

Jacobjeevan · 2025-02-03T06:52:01Z

src/components/Users/UserListAndCard.tsx

-        <Badge variant="secondary" className="bg-yellow-100 whitespace-nowrap">
+        <Badge
+          variant="secondary"
+          className="bg-yellow-100 whitespace md:px-0 md:py-0 "


Jacobjeevan · 2025-02-03T07:20:13Z

Try to think ahead 👍 Since you are adjusting this page for responsiveness anyways, check if any other elements need to be adjusted as well.

In this case, the add/link user buttons are too close to the text for mobile.

DonXavierdev · 2025-02-03T17:05:03Z

@Jacobjeevan Adding back break-word classname due to long username overflow

nihal467 · 2025-02-04T10:36:49Z

LGTM

github-actions · 2025-02-04T11:48:58Z

@DonXavierdev Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Add Word breaks,Remove Extra padding

cd890ef

DonXavierdev requested a review from a team as a code owner February 2, 2025 19:14

coderabbitai bot reviewed Feb 2, 2025

View reviewed changes

Jacobjeevan requested changes Feb 3, 2025

View reviewed changes

Jacobjeevan added the changes required label Feb 3, 2025

Switch to 2 containers for lg

f158583

DonXavierdev requested a review from Jacobjeevan February 3, 2025 07:12

Jacobjeevan added needs testing needs review and removed changes required needs testing needs review labels Feb 3, 2025

rithviknishad approved these changes Feb 3, 2025

View reviewed changes

rithviknishad added the needs review label Feb 3, 2025

adjust button margin.

08b0418

Jacobjeevan approved these changes Feb 4, 2025

View reviewed changes

Jacobjeevan added needs testing and removed needs review labels Feb 4, 2025

nihal467 added tested reviewed reviewed by a core member and removed needs testing labels Feb 4, 2025

rithviknishad merged commit 73853b5 into ohcnetwork:develop Feb 4, 2025
15 checks passed

coderabbitai bot mentioned this pull request Feb 5, 2025

fix: Organization Users page needs responsiveness #10413

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix : User Detail Responsiveness #10366

Fix : User Detail Responsiveness #10366

DonXavierdev commented Feb 2, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 2, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 2, 2025 •

edited

Loading

coderabbitai bot left a comment

Jacobjeevan Feb 3, 2025

Jacobjeevan Feb 3, 2025

Jacobjeevan commented Feb 3, 2025 •

edited

Loading

DonXavierdev commented Feb 3, 2025

nihal467 commented Feb 4, 2025

github-actions bot commented Feb 4, 2025

Fix : User Detail Responsiveness #10366

Fix : User Detail Responsiveness #10366

Conversation

DonXavierdev commented Feb 2, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 2, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 2, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Jacobjeevan Feb 3, 2025

Choose a reason for hiding this comment

Jacobjeevan Feb 3, 2025

Choose a reason for hiding this comment

Jacobjeevan commented Feb 3, 2025 • edited Loading

DonXavierdev commented Feb 3, 2025

nihal467 commented Feb 4, 2025

github-actions bot commented Feb 4, 2025

DonXavierdev commented Feb 2, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 2, 2025 •

edited

Loading

Jacobjeevan commented Feb 3, 2025 •

edited

Loading