Fixed the facility redirection in organisation #10328
Conversation
WalkthroughThe pull request involves a modification to the navigation path in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying care-fe with
|
| Latest commit: |
319cbb9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6e07207a.care-fe.pages.dev |
| Branch Preview URL: | https://facility-redirection.care-fe.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/pages/Organization/OrganizationFacilities.tsx (1)
159-159: Add a comment explaining the redirection change.Consider adding a code comment explaining why users are being redirected to the settings page instead of the overview page. This will help other developers understand the intent behind this change.
<Link + {/* Redirecting to settings/general instead of overview as per ISSUE-XXX */} href={`/facility/${facility.id}/settings/general`} className="text-sm w-full hover:underline" >
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/pages/Organization/OrganizationFacilities.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: cypress-run (1)
🔇 Additional comments (1)
src/pages/Organization/OrganizationFacilities.tsx (1)
159-159: Verify that the new route exists and is accessible.The redirection has been changed from overview to settings/general page. While the change looks good, we should verify that this route exists and is properly configured.
Let's verify the route configuration:
✅ Verification successful
The route change is properly configured and valid ✅
The new path
/facility/${facility.id}/settings/generalis handled by the wildcard route in FacilityRoutes.tsx. The different landing pages (settings vs overview) from different entry points appear to be an intentional UX pattern based on the context of use.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the new route path exists in the router configuration # and if there are any other components still using the old path # Search for route definitions echo "Checking route definitions..." rg -A 5 "facility/.*settings/general" # Search for any remaining references to the old path echo "Checking for old path usage..." rg -A 5 "facility/.*overview"Length of output: 2666
Script:
#!/bin/bash # Search for any settings-related routes in the facility context echo "Checking facility settings routes..." rg "facility.*settings" src/Routers/ # Search for the FacilitySettings component echo "Checking for FacilitySettings component..." fd -e tsx -e ts "FacilitySettings"Length of output: 348
Script:
#!/bin/bash # Check the implementation of the settings route echo "Checking settings route implementation..." rg -A 10 "facility/:facilityId/settings\*" src/Routers/routes/FacilityRoutes.tsxLength of output: 321
CARE
|
||||||||||||||||||||||||||||
| Project |
CARE
|
| Branch Review |
facility-redirection
|
| Run status |
|
| Run duration | 05m 50s |
| Commit |
|
| Committer | Mohammed Nihal |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
10
|
| View all changes introduced in this branch ↗︎ | |
|
@nihal467 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit