Fixed alignment of components in mobile view #10038

manmeetnagii · 2025-01-18T02:44:31Z

Proposed Changes

Fixes Minor Issue: Misalignment of Some Components in Mobile View #10037

1. Login Form

2. Go to Poojappura PHC Facility > Appointment > Click on any appointment and see card

3. Go to Poojappura PHC Facility > Encounter > View Deatils > Patient Details > Requests > Create Request and scroll down to Contact Information

4. Go to Poojappura PHC Facility > Encounter > View Details > Patient Details

5 Go to Poojappura PHC Facility > Search Patient > Search for any patient (8888888887) > See the gap in buttons in verify DOB modal

@ohcnetwork/care-fe-code-reviewers

Summary by CodeRabbit

New Features
- Added a user-friendly message for not found resources.
Style
- Updated login form container styling to adjust element alignment.
- Enhanced responsiveness of contact information layout in the resource creation form.
- Improved responsiveness and layout of the appointment token card.
- Adjusted layout in the appointment detail component for better display on different screen sizes.
Bug Fixes
- Updated message for no updates available in patient updates section.
Chores
- Adjusted layout and spacing in various components for better visual organization.
- Modified button styling in the patient index component for improved spacing.

coderabbitai · 2025-01-18T02:44:39Z

Walkthrough

The pull request includes several modifications across multiple components, primarily focusing on CSS class adjustments to improve layout and responsiveness. Changes were made to the Login.tsx, PatientDetailsTab, PatientHome, PatientIndex, ResourceCreate, and AppointmentTokenCard components, enhancing the user interface without altering the underlying functionality.

Changes

File	Change Summary
`src/components/Auth/Login.tsx`	Modified div className from `"relative h-full items-center justify-center md:flex"` to `"relative h-full items-center flex justify-center md:flex"`
`public/locale/en.json`	Added new key `"not_found": "Not Found"` for localization support.
`src/components/Patient/PatientDetailsTab/patientUpdates.tsx`	Changed displayed message from `{t("no_updates_found")}` to `{t("no_update_available")}`.
`src/components/Patient/PatientHome.tsx`	Removed `mx-3` class from div, affecting horizontal margin.
`src/components/Patient/PatientIndex.tsx`	Added `mb-2` class to the "verify" button for bottom margin.
`src/components/Resource/ResourceCreate.tsx`	Changed layout class to `flex-col lg:flex-row gap-2 lg:items-center` for responsive design.
`src/pages/Appointments/components/AppointmentTokenCard.tsx`	Updated classNames for responsive width and background image size adjustments.
`src/pages/Appointments/AppointmentDetail.tsx`	Changed flex layout classes from `md:flex-row` to `md:flex-col lg:flex-row`.

Assessment against linked issues

Objective	Addressed	Explanation
Center login form in mobile view [#10037]	✅
Adjust layout for better alignment in mobile view [#10037]	✅

Possibly related PRs

Add View Consultation Button #9296: The changes in the main PR involve modifications to the PatientHome.tsx file, which also includes adjustments to the layout and styling of components, similar to the changes made in the AppointmentTokenCard.tsx file in this PR.
Support for rescheduling appointment #9956: The main PR introduces a new state variable for managing appointment rescheduling, which aligns with the changes in the AppointmentTokenCard.tsx where responsive design elements are added, indicating a focus on improving user interactions related to appointments.
Appointment Token UI mobile fix #10096: The changes in the main PR focus on mobile UI fixes, which directly relate to the modifications made in the AppointmentTokenCard.tsx for responsive design, ensuring better usability on mobile devices.

Suggested labels

tested

Suggested reviewers

rithviknishad
Jacobjeevan

Poem

🐰 A rabbit's tale of CSS delight,
Where classes dance and pixels align just right,
One tweak, one flex, a mobile view so neat,
Login form centered, now perfectly sweet!
Code magic happens in just one line 🔧

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f992a6 and 73c3acd.

📒 Files selected for processing (2)

public/locale/en.json (1 hunks)
src/components/Auth/Login.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

public/locale/en.json
src/components/Auth/Login.tsx

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: cypress-run (1)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-18T02:46:03Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`73c3acd`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67922a94e182ef0008ec53ae
😎 Deploy Preview	https://deploy-preview-10038--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…login-form

nihal467 · 2025-01-21T11:14:10Z

@manmeetnagii

the appointments card overflow still exist in middle screen devices such as ipad air
modify your description in issues and PR for reviewers to understand which page is having this issues

…login-form

manmeetnagii · 2025-01-22T02:21:57Z

@manmeetnagii

the appointments card overflow still exist in middle screen devices such as ipad air

modify your description in issues and PR for reviewers to understand which page is having this issues

@nihal467 done

github-actions · 2025-01-22T10:09:08Z

👋 Hi, @manmeetnagii,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions · 2025-01-23T17:23:23Z

@manmeetnagii Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

fix alignment of login form

11e9b79

manmeetnagii requested a review from a team as a code owner January 18, 2025 02:44

fix mobile view

71444ae

manmeetnagii changed the title ~~Fixed alignment of login form~~ Fixed alignment of components in mobile view Jan 18, 2025

Jacobjeevan added needs testing needs review labels Jan 20, 2025

Jacobjeevan approved these changes Jan 20, 2025

View reviewed changes

Merge branch 'develop' of https://github.com/ohcnetwork/care_fe into …

a290901

…login-form

nihal467 added test failed and removed needs testing needs review labels Jan 21, 2025

manmeetnagii added 4 commits January 21, 2025 18:07

Merge branch 'develop' of https://github.com/ohcnetwork/care_fe into …

9ad2b11

…login-form

Merge branch 'develop' of https://github.com/ohcnetwork/care_fe into …

138a745

…login-form

Merge branch 'develop' of https://github.com/ohcnetwork/care_fe into …

6ead1ea

…login-form

fixed responsiveness for medium devices

573e53c

github-actions bot added the merge conflict pull requests with merge conflict label Jan 22, 2025

Merge branch 'develop' into login-form

4f992a6

github-actions bot removed the merge conflict pull requests with merge conflict label Jan 22, 2025

Jacobjeevan added needs testing needs review and removed test failed labels Jan 23, 2025

Jacobjeevan requested a review from nihal467 January 23, 2025 02:07

Merge branch 'develop' into login-form

73c3acd

nihal467 added tested and removed needs testing labels Jan 23, 2025

nihal467 approved these changes Jan 23, 2025

View reviewed changes

rithviknishad approved these changes Jan 23, 2025

View reviewed changes

rithviknishad merged commit 9bae571 into ohcnetwork:develop Jan 23, 2025
17 checks passed

manmeetnagii added a commit to manmeetnagii/care_fe that referenced this pull request Jan 23, 2025

Fixed alignment of components in mobile view (ohcnetwork#10038)

60a0c2c

This was referenced Jan 24, 2025

Fix: Unwanted scrolling and spacing on availability page #10130

Merged

Fix the multiple Care Icon in smaller Screen for Patient View #10217

Closed

manmeetnagii deleted the login-form branch January 27, 2025 21:37

This was referenced Feb 3, 2025

Fix: Add fallback url for goback() | OTP field auto focus | Add Search Feature for users #10146

Open

Fixed background and font for appointments card #10445

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed alignment of components in mobile view #10038

Fixed alignment of components in mobile view #10038

manmeetnagii commented Jan 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 18, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 18, 2025 •

edited

Loading

nihal467 commented Jan 21, 2025 •

edited

Loading

manmeetnagii commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

github-actions bot commented Jan 23, 2025

Fixed alignment of components in mobile view #10038

Fixed alignment of components in mobile view #10038

Conversation

manmeetnagii commented Jan 18, 2025 • edited by coderabbitai bot Loading

Proposed Changes

1. Login Form

2. Go to Poojappura PHC Facility > Appointment > Click on any appointment and see card

3. Go to Poojappura PHC Facility > Encounter > View Deatils > Patient Details > Requests > Create Request and scroll down to Contact Information

4. Go to Poojappura PHC Facility > Encounter > View Details > Patient Details

5 Go to Poojappura PHC Facility > Search Patient > Search for any patient (8888888887) > See the gap in buttons in verify DOB modal

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai bot commented Jan 18, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 18, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

nihal467 commented Jan 21, 2025 • edited Loading

manmeetnagii commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

github-actions bot commented Jan 23, 2025

manmeetnagii commented Jan 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 18, 2025 •

edited

Loading

nihal467 commented Jan 21, 2025 •

edited

Loading