Skip to content

Commit

Permalink
showing errors on wrong numbers in PhoneNumberFormField (#6675)
Browse files Browse the repository at this point in the history
* showing errors wrong number in PhoneNumberFormField

* made error field show only when there is an error

* Update src/Components/Form/FormFields/FormField.tsx

Co-authored-by: Rithvik Nishad <[email protected]>

* changed margin to remove extra space in userfilter

* Apply suggestions from code review

---------

Co-authored-by: Rithvik Nishad <[email protected]>
  • Loading branch information
kshitijv256 and rithviknishad authored Nov 30, 2023
1 parent a18016b commit fe28c4e
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 21 deletions.
1 change: 0 additions & 1 deletion src/Components/Shifting/ListFilter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,6 @@ export default function ListFilter(props: any) {
name="patient_phone_number"
value={filterState.patient_phone_number}
onChange={handleFormFieldChange}
errorClassName="hidden"
types={["mobile", "landline"]}
/>
<DateRangeFormField
Expand Down
40 changes: 20 additions & 20 deletions src/Components/Users/UserFilter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -134,26 +134,26 @@ export default function UserFilter(props: any) {
errors={""}
/>
</div>

<PhoneNumberFormField
label="Phone Number"
name="phone_number"
placeholder="Phone Number"
value={filterState.phone_number}
onChange={handleChange}
errorClassName="hidden"
types={["mobile", "landline"]}
/>

<PhoneNumberFormField
label="Whatsapp Number"
name="alt_phone_number"
placeholder="WhatsApp Phone Number"
value={filterState.alt_phone_number}
onChange={handleChange}
errorClassName="hidden"
types={["mobile"]}
/>
<div className="-mb-4">
<PhoneNumberFormField
label="Phone Number"
name="phone_number"
placeholder="Phone Number"
value={filterState.phone_number}
onChange={handleChange}
types={["mobile", "landline"]}
/>
</div>
<div className="-mb-4">
<PhoneNumberFormField
label="Whatsapp Number"
name="alt_phone_number"
placeholder="WhatsApp Phone Number"
value={filterState.alt_phone_number}
onChange={handleChange}
types={["mobile"]}
/>
</div>
</FiltersSlideover>
);
}

0 comments on commit fe28c4e

Please sign in to comment.