Avoid windows crate types in public API
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohadravid
force-pushed
the
bugfix/semver-and-windows-crate
branch
from
66315b4 to
d2450e0
Compare
|
Sorry about not getting to this yesterday! This looks great. Only things I'd add are:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #3 +
Fix a bug in query_process_id_listwhich I'll backport.We can't have
impl From<windows::...> for Handle(for a customHandletype) because then everywindowsversion change will be a breaking change 😢, so I decided to use plainisizefor simplicity.Currently a draft, since I still need to exposeJOBOBJECT_EXTENDED_LIMIT_INFORMATIONin a sanitize way.Decided not to expose it since the user always needs to mark the right flags which is error prone, better to have people submit a PR.
cc @Kharosx0 @sunshowers