Add tooltip with itp and cores/itp to homepage #1566
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppigazzini
reviewed
Feb 15, 2023
|
DEV updated, LGTM, just nit picking. |
This allows more advanced users to keep a closer eye on the server without confusing new viewers (take 2, cleaner syntax, more consistent style with : instead of =)
ppigazzini
reviewed
Aug 23, 2023
| @@ -15,7 +15,7 @@ | |||
| <div class="col-6 col-sm"> | |||
| <div class="card card-lg-sm text-center"> | |||
| <div class="card-header text-nowrap" title="Cores">Cores</div> | |||
| <div class="card-body"> | |||
| <div class="card-body" title="${f"itp: {itp:d}, c/i: {cores/itp:.2f}"}"> | |||
There was a problem hiding this comment.
- <div class="card-body" title="${f"itp: {itp:d}, c/i: {cores/itp:.2f}"}">
+ <div class="card-body" title="${f'itp: {itp:.0f}, c/i: {cores/itp:.2f}'}">
|
I fixed the conflicts, fixed 2 more errors in the original PR, rebased on master and ran on DEV. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows more advanced users to keep a closer eye on the server without confusing new viewers