cap capacity

odygrd · Apr 17, 2023 · 57f8104 · 57f8104
1 parent 0e6285c
commit 57f8104
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/quill/include/quill/detail/spsc_queue/UnboundedQueue.h b/quill/include/quill/detail/spsc_queue/UnboundedQueue.h
@@ -102,7 +102,9 @@ class UnboundedQueue
     }
 
     // bounded queue max power of 2 capacity since uint32_t type is used to hold the value 2147483648 bytes
-    constexpr uint64_t max_bounded_queue_capacity = (std::numeric_limits<uint32_t>::max() >> 1) + 1;
+    constexpr uint64_t max_bounded_queue_capacity =
+      (std::numeric_limits<BoundedQueue::integer_type>::max() >> 1) + 1;
+
     if (QUILL_UNLIKELY(capacity > max_bounded_queue_capacity))
     {
       if ((nbytes + 1) > max_bounded_queue_capacity)

diff --git a/quill/src/detail/backend/TransitEventBuffer.cpp b/quill/src/detail/backend/TransitEventBuffer.cpp
@@ -134,9 +134,12 @@ TransitEvent* UnboundedTransitEventBuffer::back() noexcept
   {
     // buffer doesn't have enough space
     uint64_t capacity = static_cast<uint64_t>(_writer->transit_buffer.capacity()) * 2ull;
-    if (QUILL_UNLIKELY(capacity > std::numeric_limits<uint32_t>::max()))
+    constexpr uint64_t max_bounded_queue_capacity =
+      (std::numeric_limits<BoundedTransitEventBuffer::integer_type>::max() >> 1) + 1;
+
+    if (QUILL_UNLIKELY(capacity > max_bounded_queue_capacity))
     {
-      capacity = std::numeric_limits<uint32_t>::max();
+      capacity = max_bounded_queue_capacity;
     }
 
     auto new_node = new Node{static_cast<uint32_t>(capacity)};