Make frames_per_file calculation in create_file respect outer chunk dimension #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDYendell
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
I have had a go at documenting some of the confusion in the API that this change has uncovered in #365. I am happy for this to be merged now even if it does increase that confusion further, as it is an improvement on the current behaviour.
@timcnicholls and @ajgdls if you could have a read through #365 to see if you agree/disagree and have any further suggestions that would be great 🙂
ajgdls
approved these changes
Nov 21, 2024
|
Happy to merge this when you're ready @timcnicholls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #360 , where the file writer plugin errors when attempting to write output files for datasets with outer chunk dimension > 1 over multiple files with a fixed total number of frames. This is fixed by making the
frames_per_filecalculation inAcquisition::create_fileinclude the outer chunk dimension.Fixes #360