Removing files not related to readers and writers. Tests point to OpenFAST r-test #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ading and writing only
mayankchetan
changed the title
mayankchetan
changed the title
13 tasks
There was a problem hiding this comment.
Thanks for this! It's nice to be able to remove those dependencies and all that duplicated test code. It was especially useful to have your insight on which of the files from WEIS weren't needed. I have a question below about including ROSCO and will probably have to shift the structure of the python package around a little for some packaging reasons but this looks great otherwise! I'll merge into my fork when I'm ready
cortadocodes
merged commit 0012ca8
into
octue:add-weis-readers-and-writers
0 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in detail here: OpenFAST#2188 (comment)