fixes for mms attachment view/share is suboptimal (#242) and other small fixups #254
+285
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to media store when sharing. fixed using wrong attachment class for vcards (use lowercase on both sides of attachment mime type comparison) added share button to audio attachment preview removed old fileprovider that was never used added content provider to provide mms attachments to external activities using a filename - not mms part id - so they can be saved externally with a proper name fix bug when re-using attachment viewholder that has previously had text fixed bug of image attachments always being named 'image' rather than their filename added share button to generic file attachment type in compose message list and removed onclick handler for viewing
|
I'm a bit torn on the UX. downloading sounds like it would be used more often than sharing, and both aren't immediate actions. should those be in the media viewer? should we add a vcard preview? 🤔 having the share button there for every media feels like it would get annoying and not used that often. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed to not save message attachments to media store when sharing.
fixed using wrong attachment class for vcards (use lowercase on both sides of attachment mime type comparison)
added share button to audio attachment preview.
removed old fileprovider that was never used.
added content provider to provide mms attachments to external activities using a filename - not mms part id - so they can be saved externally with a proper name.
fix bug when re-using attachment viewholder that has previously had text.
fixed bug of image attachments always being named 'image' rather than their filename.
added share button to generic file attachment type in compose message list and removed onclick handler for viewing.
closes #242