Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mms image compression bug not compressing #243

Conversation

gavine99
Copy link
Contributor

@gavine99 gavine99 commented Jan 29, 2025

compression was not being applied to images and gifs.

should satisfy issue #116

  • suggest this bugfix goes into latest beta build so it can be well tested

@barongi
Copy link

barongi commented Jan 29, 2025

Using the latest beta v4.0.9
Samsung A55 Android 14

Doesn't compress gif file. A smaller gif gets sent but a 2Mb sized one does not. Tried to send the 2Mb using no compression, 2000kb compression and 1000kb compression. No gif was sent. Attaching example gifs, a small owl and a large Metallica. Also tried the new "Attach any file"-option. Same result.
Owl
Ride The Lightning

@Turhvjbufv
Copy link

Using the latest beta v4.0.9
Samsung A55 Android 14

Doesn't compress gif file. A smaller gif gets sent but a 2Mb sized one does not. Tried to send the 2Mb using no compression, 2000kb compression and 1000kb compression. No gif was sent. Attaching example gifs, a small owl and a large Metallica. Also tried the new "Attach any file"-option. Same result.
Owl
Ride The Lightning

This didn't get released with the beta.. look at the time this pr was made and look on when beta was released

@octoshrimpy octoshrimpy merged commit 8c820db into octoshrimpy:master Jan 29, 2025
1 of 2 checks passed
@gavine99 gavine99 deleted the attachment_compression_doesnt_work_116 branch February 1, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants