-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build-on-pull.yml #239
base: master
Are you sure you want to change the base?
Conversation
Update's versions.
I am very sorry, I realized I should have made this a draft until I get the build to actually work. Very sorry, I am still new to git... |
@Inhishonor no worries! we are all learning here! Go ahead and mark it as ready whenever you are. :) |
Update Versions and add code to add the signing keys to the build.
@octoshrimpy Is the code that injects the signing keys right? I merely copied and pasted it from another action in this repo. I am not sure how the secrets are labeled within the secrets file. |
I believe that is correct. |
Fixes the formatting of the keystore injections.
Changes it to only set up a NoAnalyticsDebug.
Remove --stacktrace.
I was able to get it to successfully run. To do so, I had to only build a No Analytics build, as there are too many deprecations and errors in the Analytics build. As of right now, the code says to upload artifacts (test results) to a folder, however the folder doesn't exist. If you don't need that I could remove that from the code. But at this point it should work. |
This pr updates all the versions in the build-on-pull.yml. Note, this does not actually make this action succeed. It only allows the build to start. The build then makes it about 3/4 of the way through and fails with a signing keys error. I am currently working on this, but I have not made much headway. My apologies @Ilithy for jumping in on this. Thanks!