Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pr 225 render issue #232

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

gavine99
Copy link
Contributor

removed audio binder state maintenance from audiobinder on the compose screen into messagesadapter class. fixed other ui issues also related to state loss in audiobinder and re-use of viewholders

added onclick listener to audiobinder. removed recycledviewpool from parts adapter because it was recycling too fast and messing with attachment/part selection

gavine99 added 2 commits January 27, 2025 19:31
…n into messagesadapter class. fixed other ui issues also related to state loss in audiobinder and re-use of viewholders
…parts adapter because it was recycling too fast and messing with attachment/part selection
@octoshrimpy
Copy link
Owner

@Ilithy Test failed because deprecated artifacts v2: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/ would you be willing to fix that?

@octoshrimpy octoshrimpy merged commit 77ce54f into octoshrimpy:master Jan 27, 2025
1 of 2 checks passed
@gavine99 gavine99 deleted the fix_pr_225_render_issue branch February 1, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants