Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send delayed sms immediately #221

Merged
merged 8 commits into from
Jan 29, 2025

Conversation

gavine99
Copy link
Contributor

added a 'send now' button to delayed sms send which, when long pressed, aborts the delay and sends the sms immediately.

moved existing 'cancel send' button to far left of screen so it's always in the same ui position for better muscle memory access.

satisfies feature request #35

image

@octoshrimpy
Copy link
Owner

octoshrimpy commented Jan 22, 2025

I've had thoughts on the UI for this. would it be better to have the send now be a show-on-swipe/longpress of message? that way there aren't a lot of buttons floating around in the convo message. likewise, the cancel button could also be moved there, and just show a lil countdown on bottom right of the message. thoughts?

@gavine99
Copy link
Contributor Author

agreed about multiple buttons looking ugly.
long press event is already used to select message. short press toggles display/hide status.
swipe is available but wouldn't be evident to users unless there's some sort of instruction on screen.
maybe instead of 'sending...' change status to 'swipe left to cancel, right to send now. sending in X' with count down ?

@lascapi
Copy link

lascapi commented Jan 23, 2025

Hello, my two cents in one image

quik-1

Like that the button to send is always at the same place.

@Turhvjbufv
Copy link

agreed about multiple buttons looking ugly.
long press event is already used to select message. short press toggles display/hide status.
swipe is available but wouldn't be evident to users unless there's some sort of instruction on screen.
maybe instead of 'sending...' change status to 'swipe left to cancel, right to send now. sending in X' with count down ?

I like that idea

@octoshrimpy
Copy link
Owner

I'm keen on keeping helper text under a to-send message to a minimum. how about "swipe for actions" with the round loader? on swipe, could do something like this mockup, where swipe one way is send now, swipe other is cancel. long press could show both those options as well as a "edit send timedate" option.
image

this way when scrolling past, the message is mostly unobtrusive without having to dig into menus for all the options.

a related idea: maybe have a setting as well for "show only scheduled messages coming up within x timeframe"? If I schedule a happy b-day sms for 10 months from now, it makes no sense to have it there every time I open up the convo, but would be nice to have it show up a week before it's sent. Maybe a "3 scheduled" text somewhere? maybe even just an icon next to send? let's spitball something.

@lascapi
Copy link

lascapi commented Jan 25, 2025

Hi, i already said what I'm thinking, but I didn't say that at some point you/we should ask a UX designer because the UI become super random!

Maybe I can ask here : https://opensourcedesign.net/
If the dev team is ready to work for that of course !

@gavine99
Copy link
Contributor Author

the more i think about the hard work involved in all these great ideas, the more i like the original pr ui. heh

just so we're on the same page... this pr is for delayed send which means a max of 10 seconds that the send now and cancel buttons are on screen. and if set to 3 or 5 seconds delay it's too short a time to discover to swipe left or right or up or... oh no! my message sent before i remembered which way to slide to cancel it.

image

i think the swiping and setting new schedule stuff is good for scheduled messages but could be overkill for delayed.

how about just move the send now button to the rhs for the (max) 10 seconds it's displayed;

image

@Turhvjbufv
Copy link

the more i think about the hard work involved in all these great ideas, the more i like the original pr ui. heh

just so we're on the same page... this pr is for delayed send which means a max of 10 seconds that the send now and cancel buttons are on screen. and if set to 3 or 5 seconds delay it's too short a time to discover to swipe left or right or up or... oh no! my message sent before i remembered which way to slide to cancel it.

image

i think the swiping and setting new schedule stuff is good for scheduled messages but could be overkill for delayed.

how about just move the send now button to the rhs for the (max) 10 seconds it's displayed;

image

Lol yeah
I think having it for all delay options is better

@octoshrimpy
Copy link
Owner

i think the swiping and setting new schedule stuff is good for scheduled messages but could be overkill for delayed.

...OH. I misunderstood and thought this was for scheduled messages!! You are absolutely correct.

gavine99 added 4 commits January 28, 2025 16:03
…'send now' to send a delayed message immediately
moved send now button to rhs.
changed send now button long press to short/normal press
…mmediately_35

# Conflicts:
#	presentation/src/main/java/com/moez/QKSMS/feature/compose/MessagesAdapter.kt
#	presentation/src/main/res/layout/message_list_item_out.xml
@gavine99
Copy link
Contributor Author

gavine99 commented Jan 28, 2025

rebased pr to master to remove conflicts. moved send now button to rhs. made send now button normal click, not long click.
looks a bit less cluttered with more separated buttons i think.
image

@octoshrimpy
Copy link
Owner

@gavine99 small nitpick, could you remove the round shade and background around the stop and send buttons? what does it look like when the text is multiline? does the stop align to top or bottom? I got a gut feeling it should be aligned to bottom because closer to where user is interacting (input bar) but unsure.

@gavine99
Copy link
Contributor Author

gavine99 commented Jan 29, 2025

button shadows removed. layouts rejiggered to ensure buttons at bottom of long text.

my branch is updated and able to merge to master and hopefully this can sneak into the 4.0.9 alpha release.

short text;
image

long text;
image

@octoshrimpy octoshrimpy merged commit d376f1b into octoshrimpy:master Jan 29, 2025
1 of 2 checks passed
@gavine99 gavine99 deleted the send_immediately_35 branch February 1, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants