-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send delayed sms immediately #221
Conversation
…'send now' to send a delayed message immediately
…list_item_out view
I've had thoughts on the UI for this. would it be better to have the send now be a show-on-swipe/longpress of message? that way there aren't a lot of buttons floating around in the convo message. likewise, the cancel button could also be moved there, and just show a lil countdown on bottom right of the message. thoughts? |
agreed about multiple buttons looking ugly. |
I like that idea |
Hi, i already said what I'm thinking, but I didn't say that at some point you/we should ask a UX designer because the UI become super random! Maybe I can ask here : https://opensourcedesign.net/ |
the more i think about the hard work involved in all these great ideas, the more i like the original pr ui. heh just so we're on the same page... this pr is for delayed send which means a max of 10 seconds that the send now and cancel buttons are on screen. and if set to 3 or 5 seconds delay it's too short a time to discover to swipe left or right or up or... oh no! my message sent before i remembered which way to slide to cancel it. i think the swiping and setting new schedule stuff is good for scheduled messages but could be overkill for delayed. how about just move the send now button to the rhs for the (max) 10 seconds it's displayed; |
Lol yeah |
...OH. I misunderstood and thought this was for scheduled messages!! You are absolutely correct. |
…'send now' to send a delayed message immediately
…list_item_out view
moved send now button to rhs. changed send now button long press to short/normal press
…mmediately_35 # Conflicts: # presentation/src/main/java/com/moez/QKSMS/feature/compose/MessagesAdapter.kt # presentation/src/main/res/layout/message_list_item_out.xml
@gavine99 small nitpick, could you remove the round shade and background around the stop and send buttons? what does it look like when the text is multiline? does the stop align to top or bottom? I got a gut feeling it should be aligned to bottom because closer to where user is interacting (input bar) but unsure. |
…utton shadows. make buttons float bottom
added a 'send now' button to delayed sms send which, when long pressed, aborts the delay and sends the sms immediately.
moved existing 'cancel send' button to far left of screen so it's always in the same ui position for better muscle memory access.
satisfies feature request #35