-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Simplify directories #323
Conversation
(unnecessary)
(git doesn't recognise simple capitalisation changes)
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are great changes @Lamparter. A couple of things to get this all wrapped up...
- You'l'l need to modify the workflow for the generator to make sure the models go in the
src/
folder now >./Octokit.GraphQL/
to./src/Octokit.GraphQL/
- This might also be a good time to move to .NET 8 / at least move the generator from
netcoreapp3.1
tonet8.0
- As a factor of clean up we can delete
.travis.yaml
,appveyor.yaml
, and the*.ncrunchsolution
files - Given that this is already a "large" PR due to the move you might consider running the generator and checking in the results
dotnet run --project ./Tools/Generate/Generate.csproj -- $GH_TOKEN ./Octokit.GraphQL/
to update all of the models - The
dotnetcore.yml
workflow should be updated as well to reflect the new structure - The
integration-tests.yml
workflow should be updated as well to reflect the new structure - The nuspec file
Octokit.GraphQL.nuspec
should be updated to reflect the new structure
Thanks for the review! Most of these change I've implemented (readme, src dir, net8.0) were suggested by the kind @0x5bfa so thank him for having lots of ideas for this project! ❤️ (you'll notice most of our changes are in our collaboration repo RiversideValley/Octokit) |
Keep it there, I think that's the right move unless you run into anything that would prevent you from keeping them separate.
|
We should avoid updating models here. Let's hold off:
Thank you for the review. If this is hard to review, we probably can separate the changes into a few PRs, merge into another branch on this repo and then merge that branch into the main. @nickfloyd Here's the change list:
|
@0x5bfa Where do you want to bring these changes? |
To the upcoming PR. |
Signed-off-by: 0x5BFA <[email protected]>
Signed-off-by: 0x5BFA <[email protected]>
Signed-off-by: 0x5BFA <[email protected]>
Signed-off-by: 0x5BFA <[email protected]>
Signed-off-by: 0x5BFA <[email protected]>
I fixed the CI.
|
https://github.com/octokit/octokit.graphql.net/actions/runs/10925402467/job/30326798453?pr=325#step:9:15 |
afc8fb7
to
282156b
Compare
Hey @Lamparter & @0x5bfa thanks for the changes here ❤️. Everything looks good. Once you get the merge conflict resolved I'll get this merged in. Also, re: #321 - once you move that one out of draft I'll take a look at it. Again, thank you both for making this and our community better! |
Some CI is failing, let's fix shortly. |
Oh crap I forgot to update the codebase structure in the README |
Related: #293 (hey there!)
This pull request was authored on behalf of @RiversideValley
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
No
Hello (for the third time) 😁
In this PR, I (on behalf of @0x5bfa) have simplified the root directory/subdirectories to match common practices on GitHub. Took a while to get the configuration right, but everything builds correctly and packages are references as they should be.