Skip to content

Commit

Permalink
Bump required octodns >= 1.5, address pending deprecations
Browse files Browse the repository at this point in the history
  • Loading branch information
ross committed Oct 23, 2024
1 parent 6676901 commit cbb1010
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 22 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## v1.0.0 - 2024-??-?? - ???

* Address pending octoDNS 2.x deprecations, require minimum of 1.5.x

## v0.0.1 - 2022-01-07 - Moving

#### Nothworthy Changes
Expand Down
2 changes: 0 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,5 @@ sections="FUTURE,STDLIB,THIRDPARTY,OCTODNS,FIRSTPARTY,LOCALFOLDER"
[tool.pytest.ini_options]
filterwarnings = [
'error',
# TODO: remove once octodns 2.0 has been released
'ignore:.*DEPRECATED.*2.0',
]
pythonpath = "."
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def version():
),
'test': tests_require,
},
install_requires=('octodns>=0.9.14', 'requests>=2.27.0'),
install_requires=('octodns>=1.5.0', 'requests>=2.27.0'),
license='MIT',
long_description=long_description,
long_description_content_type='text/markdown',
Expand Down
19 changes: 1 addition & 18 deletions tests/config/unit.tests.yaml
Original file line number Diff line number Diff line change
@@ -1,19 +1,6 @@
---
? ''
: - geo:
AF:
- 2.2.3.4
- 2.2.3.5
AS-JP:
- 3.2.3.4
- 3.2.3.5
NA-US:
- 4.2.3.4
- 4.2.3.5
NA-US-CA:
- 5.2.3.4
- 5.2.3.5
ttl: 300
: - ttl: 300
type: A
values:
- 1.2.3.4
Expand Down Expand Up @@ -153,10 +140,6 @@ ptr:
ttl: 300
type: PTR
values: [foo.bar.com.]
spf:
ttl: 600
type: SPF
value: v=spf1 ip4:192.168.0.1/16-all
sub:
type: 'NS'
values:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_octodns_provider_easydns.py
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ def test_apply(self):
plan = provider.plan(self.expected)

# No root NS, no ignored, no excluded, no unsupported
n = len(self.expected.records) - 9
n = len(self.expected.records) - 8
self.assertEqual(n, len(plan.changes))
self.assertEqual(n, provider.apply(plan))
self.assertFalse(plan.exists)
Expand Down

0 comments on commit cbb1010

Please sign in to comment.