Wasm runtime changes #1776
Merged
Wasm runtime changes #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can later implement `-enable use-js-string` without breaking compatibility with the zarith_stubs_js Wasm runtime file.
vouillon
force-pushed
the
wasm-runtime-changes
branch
from
c2f6204 to
5094ef3
Compare
hhugo
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can later implement
-enable use-js-stringwithout breaking compatibility with the Wasm runtime file of packagezarith_stubs_js:caml_named_valueno longer assumes that strings are of typeref $string;caml_jsstring_of_substringto be used instead of the low-level functionjsstring_of_substring.