Build: dune alias for js and wasm #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vouillon, how do you feel about this setup ? |
vouillon
requested changes
Dec 9, 2024
vouillon
approved these changes
Dec 9, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to run js and wasm tests concurrently instead of relying on separate profiles.
This brings back useful profiles to just:
dev,release,with-effectsWe have separate aliases to run js (
runtest-js) and wasm (runtest-wasm) tests.The wasm build is now conditioned on the env variable WASM_OF_OCAML=true because some of the wasm deps are a bit annoying to get right for the moment (some wasm target would be included in the
@allalias).