Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci mac #1744

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Fix ci mac #1744

merged 3 commits into from
Nov 25, 2024

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Nov 25, 2024

No description provided.

@hhugo hhugo merged commit bbf4c5a into master Nov 25, 2024
18 of 20 checks passed
@hhugo hhugo deleted the fix-ci-mac branch November 25, 2024 14:37
@vouillon
Copy link
Member

I suspect we can just remove this code now.

@hhugo
Copy link
Member Author

hhugo commented Nov 25, 2024

What makes you say that ?
I would imagine that we should wait on actions/runner-images#10984

@vouillon
Copy link
Member

This seems to work for this PR: ocaml-wasm/wasm_of_ocaml#131 (ocaml-wasm/wasm_of_ocaml@4ee156e).

From what I understand, the latest macos runner image installs pkgconfig, which breaks the conf-pkg-config opam packages. So now, conf-pkg-config installs pkgconfig instead. This broke the CIs still using the previous runner image.

@hhugo
Copy link
Member Author

hhugo commented Nov 26, 2024

Are you sure this is not working just because of caches ?
I see in your branch that you've removed the previous fix ocaml-wasm/wasm_of_ocaml@4ee156e #1737 but this PR and an attempt to fix the fix :)

@vouillon
Copy link
Member

That's what I meant. You can probably just remove the previous fix.

This job is failing without the initial fix: https://github.com/ocsigen/js_of_ocaml/actions/runs/11916809033/job/33210339357
image

The initial fix no longer work for this job: https://github.com/ocsigen/js_of_ocaml/actions/runs/12012253626/job/33483052722
image

And this jobs was already using the newer image, at a much earlier date: https://github.com/coq/platform/actions/runs/11838273102/job/32987032575
image

@hhugo
Copy link
Member Author

hhugo commented Nov 26, 2024

#1746

vouillon pushed a commit to OlivierNicole/js_of_ocaml that referenced this pull request Nov 26, 2024
hhugo added a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants