Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime: no longer use arguments #1740

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Runtime: no longer use arguments #1740

merged 3 commits into from
Dec 9, 2024

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Nov 21, 2024

subset of #1682

@hhugo
Copy link
Member Author

hhugo commented Nov 21, 2024

@TyOverby, could you test this ?

@hhugo
Copy link
Member Author

hhugo commented Nov 21, 2024

@TyOverby, if we end up merging this, we should probably also merge stdlib_modern.js and stdlib.js and get rid of stdlib_modern.js

@hhugo
Copy link
Member Author

hhugo commented Dec 4, 2024

@TyOverby, Wasm support has been merged. I hoping that it means you can now easily test this PR ?

@smorimoto
Copy link
Member

This should help simplify and increase runtime performance (a bit)

@hhugo
Copy link
Member Author

hhugo commented Dec 9, 2024

@vouillon, any opinion here ?

Copy link
Member

@vouillon vouillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the performance. This looks good otherwise.

@hhugo hhugo merged commit 145e4d2 into master Dec 9, 2024
27 checks passed
@hhugo hhugo deleted the noArguments branch December 9, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants