Compiler: exit loop early #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhugo
force-pushed
the
exit-loop-early
branch
from
74547ef to
42e128f
Compare
|
@vouillon, I've cherry-picked your implementation from wasm_of_ocaml. Do you think the same heuristic is appropriate for jsoo ? In particular, the is_small part ? |
|
We should probably try to not nest loop if unnecessary. |
hhugo
force-pushed
the
exit-loop-early
branch
4 times, most recently
from
52936d8 to
d502e2e
Compare
hhugo
force-pushed
the
exit-loop-early
branch
from
8edec29 to
cb2fdad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initially based on #1333 and #1334, then rebased on #1496.
The current implementation exits a loop as soon as possible. The generated code would be better if we allowed part of the continuations to remains inside the for-loop.