Dialog element support #1257
Merged
Dialog element support #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagotch, I've rebased this PR. Is it still blocked on tyxml ? |
|
Yes it is. Tyxml has not been released since the last available release v4.5.0 (Apr 22, 2021). I think @Drup used to manage the releases of Tyxml, but I am not sure it is the case anymore. |
|
@Drup, when should we expect the next release of tyxml ? |
vouillon
pushed a commit
that referenced
this pull request
Oct 29, 2024
* Support for dialogElement * Added cancel and close events --------- Co-authored-by: Hugo Heuzard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog
and
https://html.spec.whatwg.org/multipage/interactive-elements.html#the-dialog-element
I think that I remember that
cancelandcloseevents are not well supported, but they are part of the spec.THIS PR DEPENDS ON CURRENT TYXML MASTER, which is unreleased right now. Would a new tyxml release be good enough for this to be merged?