Making powervc-certificate optional

[irapandey]

This PR is resolving issue #85
Made changes in documentation as well as powervc-certificate is optional

[ppc64le-cloud-bot]

Welcome @irapandey! It looks like this is your first PR to ocp-power-automation/ocp4-playbooks-extras 🎉

[varad-ahirwadkar]

/lgtm

[yussufsh]

/hold

[yussufsh]

This task will fail if the above condition is true.

[irapandey]

I ran it on a cluster - it just gives a message

TASK [ocp-csi-driver : Check if the PowerVC certificate's secret is exists] *************************************************************************************************************************************************************************
ok: [localhost]

TASK [ocp-csi-driver : If the powervc-certificate does not exists in default namespace] *************************************************************************************************************************************************************
ok: [localhost] => {
    "msg": "PowerVC certificate secret is not present!"
}

TASK [ocp-csi-driver : If powervc-certificate is empty] *********************************************************************************************************************************************************************************************
ok: [localhost] => {
    "msg": "PowerVC certificate is empty! Please check the certificate's secret."
}

[irapandey]

I have removed the name parameters and replaces fail with debug

[irapandey]

TASK [ocp-csi-driver : Check if the PowerVC certificate's secret is exists] *************************************************************************************************************************************************************************
ok: [localhost]

TASK [ocp-csi-driver : If the powervc-certificate does not exists in default namespace] *************************************************************************************************************************************************************
ok: [localhost] => {
    "msg": "PowerVC certificate secret is not present!"
}

TASK [ocp-csi-driver : debug] ***********************************************************************************************************************************************************************************************************************
ok: [localhost] => {
    "msg": "PowerVC certificate is empty! Please check the certificate's secret."
}

TASK [ocp-csi-driver : Create namespace for CSI driver validation] **********************************************************************************************************************************************************************************
ok: [localhost]

[ppc64le-cloud-bot]

New changes are detected. LGTM label has been removed.

[irapandey]

@varad-ahirwadkar - can you take a look?

[varad-ahirwadkar]

Can we add one more condition to validate only if the certificate is exists powervc_certificate.resources | length != 0 ?

[irapandey]

made the changes - can you review and let me know if that looks good

[aman4433]

I believe what meant is that the second debug task should only run if the PowerVC certificate secret exists. The current condition includes a redundant check (powervc_certificate.resources | length != 0), which is already covered in the first task. Adding a name attribute would also help clarify the task's purpose.

Suggested Fix:
The check powervc_certificate.resources | length != 0 should be applied first, to validate that the secret exists. Once confirmed, we can then check whether the certificate is either not defined or empty (certificate | length == 0).

[yussufsh]

/cc @aman4433

[ppc64le-cloud-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: irapandey
Once this PR has been reviewed and has the lgtm label, please assign yussufsh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment