-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1841 pub flow - createAsset Fn #1843
Conversation
btw, the service "files" cannot be null for confidential EVM, but empty string instead...
|
then let's go with empty string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @paulo-ocean can you also merge the main branch into this PR please?
Code Climate has analyzed commit ea7562f and detected 11 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 65.7% (50% is the threshold). This pull request will bring the total coverage in the repository to 74.5% (-0.2% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have an observation and a question regarding datatoken 4 creation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can approve, the only pending point that we discovered on this PR is tackled on #1859
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
merging, any open point we can address on a separate PR, as we need to update cli and the flow was already tested anyway |
Fixes #1841 .
Changes proposed in this PR: