Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1841 pub flow - createAsset Fn #1843

Merged
merged 52 commits into from
Oct 4, 2024
Merged

Issue 1841 pub flow - createAsset Fn #1843

merged 52 commits into from
Oct 4, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Sep 3, 2024

Fixes #1841 .

Changes proposed in this PR:

  • generic function (exported) to create an asset
  • update config, set confidential evm key
  • calculate template index (from id or address)
  • if confidential evm have filesObject on constructor (no need to provider encrypt)

@paulo-ocean paulo-ocean marked this pull request as draft September 4, 2024 07:49
@paulo-ocean
Copy link
Contributor Author

btw, the service "files" cannot be null for confidential EVM, but empty string instead...
if its null the DDO does not passes against schema validation
schema:ServiceShape

....
sh:targetClass schema:Service ;
    sh:property [
        sh:path schema:id ;
        sh:datatype xsd:string ;
        sh:pattern "^(.*)$" ;
        sh:minCount 1;
        sh:maxCount 1;
    ] ;
...

@alexcos20
Copy link
Member

btw, the service "files" cannot be null for confidential EVM, but empty string instead... if its null the DDO does not passes against schema validation schema:ServiceShape

....
sh:targetClass schema:Service ;
    sh:property [
        sh:path schema:id ;
        sh:datatype xsd:string ;
        sh:pattern "^(.*)$" ;
        sh:minCount 1;
        sh:maxCount 1;
    ] ;
...

then let's go with empty string

Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @paulo-ocean can you also merge the main branch into this PR please?

Copy link

codeclimate bot commented Oct 2, 2024

Code Climate has analyzed commit ea7562f and detected 11 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 9
Duplication 2

The test coverage on the diff in this pull request is 65.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.5% (-0.2% change).

View more on Code Climate.

Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an observation and a question regarding datatoken 4 creation.

Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can approve, the only pending point that we discovered on this PR is tackled on #1859

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean
Copy link
Contributor Author

merging, any open point we can address on a separate PR, as we need to update cli and the flow was already tested anyway

@paulo-ocean paulo-ocean merged commit 7b340ad into main Oct 4, 2024
11 checks passed
@paulo-ocean paulo-ocean deleted the issue-1841-pub-flow branch October 4, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add publish flow
4 participants