Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/resync #605

Closed
Closed

Conversation

alexcos20
Copy link
Member

Fixes # .

Changes proposed in this PR:

alexcos20 and others added 30 commits June 20, 2024 13:19
…ve_shacl_validation

Feature/improve_shacl_validation
…at_increase_dialers

increase no of connections
jamiehewitt15 and others added 27 commits August 12, 2024 13:54
…ys-compute

Add remote keys for compute stages
* Create CollectFeesHandler for admin. Added tests.

* Print balance.

* Add debug log.

* Added regex validation for ethereum addresses.

* Added checks for zero address. Refactor transfer call.

* Debug logs.

* Tweak for addresses length in regex.

* fix.

* Added debug logs for handle function and refactored test for fee amount.

* Fix call.

* Fix provider wallet.

* Fix breaking change for provider wallet.

* Print error.

* Replace ReadableString with Readable.

* Added more debug logs.

* More debug.

* Use readStream instead of streamToString.

* Move test position.

* increase timeout.

* remove message from handler response.

* store tx receipt in a separate var.

* Fix unit for parseUnit.

* Fix wallet.

* Change token address.

* Print addresses.

* Changed wallet private key.

* Added logs for expected failure cases.

* Fix log for balance.

* cleanup.

* Fix review part 1.

* Fix review part 2.

* Fix review part 3.

* tweak.

* Resolve conditions. Refactor code.

* Fix review.

* Updated provider wallet.

* Make tokenAmount optional.
…eementid-stop

Issue 506 agreementid stop
…ndexing-networks

Enable indexing networks
…e-cpu

improve peer discovery time, avoid connect again on connection handler
…e-hash-git

use only git tracked files for computing code hash
…rotection

add unsafe URL & make config required for Storage classes
This reverts commit 0d7a25b, reversing
changes made to 0db9171.
}
// split jobId (which is already in hash-jobId format) and get the hash
// then get jobId which might contain dashes as well
const index = task.jobId.indexOf('-')

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
may be either an array or a string.
// split jobId (which is already in hash-jobId format) and get the hash
// then get jobId which might contain dashes as well
const index = task.jobId.indexOf('-')
const hash = task.jobId.slice(0, index)

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
may be either an array or a string.
// then get jobId which might contain dashes as well
const index = task.jobId.indexOf('-')
const hash = task.jobId.slice(0, index)
const jobId = task.jobId.slice(index + 1)

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
may be either an array or a string.
if (task.jobId) {
// split jobId (which is already in hash-jobId format) and get the hash
// then get jobId which might contain dashes as well
const index = task.jobId.indexOf('-')

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
may be either an array or a string.
// split jobId (which is already in hash-jobId format) and get the hash
// then get jobId which might contain dashes as well
const index = task.jobId.indexOf('-')
const hash = task.jobId.slice(0, index)

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
may be either an array or a string.
// split compute env (which is already in hash-envId format) and get the hash
// then get env which might contain dashes as well
const eIndex = task.environment.indexOf('-')
const hash = task.environment.slice(0, eIndex)

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
may be either an array or a string.
// then get env which might contain dashes as well
const eIndex = task.environment.indexOf('-')
const hash = task.environment.slice(0, eIndex)
const envId = task.environment.slice(eIndex + 1)

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
may be either an array or a string.
try {
// split jobId (which is already in hash-jobId format) and get the hash
// then get jobId which might contain dashes as well
const index = task.jobId.indexOf('-')

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
may be either an array or a string.
// split jobId (which is already in hash-jobId format) and get the hash
// then get jobId which might contain dashes as well
const index = task.jobId.indexOf('-')
const hash = task.jobId.slice(0, index)

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
may be either an array or a string.
// then get jobId which might contain dashes as well
const index = task.jobId.indexOf('-')
const hash = task.jobId.slice(0, index)
const jobId = task.jobId.slice(index + 1)

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
may be either an array or a string.
@alexcos20 alexcos20 closed this Aug 14, 2024
@alexcos20 alexcos20 deleted the feature/resync branch August 14, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants