Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typsense pagination #373

Merged
merged 10 commits into from
Apr 11, 2024
Merged

Typsense pagination #373

merged 10 commits into from
Apr 11, 2024

Conversation

jamiehewitt15
Copy link
Member

@jamiehewitt15 jamiehewitt15 commented Mar 25, 2024 •
edited
Loading

Fixes #330

Changes proposed in this PR:

  • Adding pagination to each of our search methods within src/components/database/index.ts
  • Updating the logs HTTP route so that it can be used for paginated requests.
  • Adding additional tests on the logs to test the pagination.

@jamiehewitt15 jamiehewitt15 changed the base branch from main to develop March 25, 2024 11:47
@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review March 26, 2024 11:53
paulo-ocean
paulo-ocean approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bogdanfazakas
bogdanfazakas approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamiehewitt15 jamiehewitt15 merged commit 0c65bbd into develop Apr 11, 2024
6 checks passed
@jamiehewitt15 jamiehewitt15 deleted the issue-330-pagination branch April 11, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce pagination for database queries
3 participants
@jamiehewitt15 @bogdanfazakas @paulo-ocean