Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the dashboard optional #338

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Conversation

jamiehewitt15
Copy link
Member

Fixes #327

Changes proposed in this PR:

  • Making the dashboard optional
  • Dashboard still runs by default, the new env is optional

To test:

export DASHBOARD="false"
npm run build
npm run start 

Navigate to http://localhost:8000/dashboard/ and there should be no dashboard.

Now run:

export DASHBOARD="true"
npm run build
npm run start 

and the dashboard should be running at http://localhost:8000/dashboard/

Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, apart that unit test we know it fails atm

Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, think we should merge first the PR with env-md docs and add the Dashboard there as well

@jamiehewitt15 jamiehewitt15 merged commit f4a2f8f into develop Mar 19, 2024
6 checks passed
@jamiehewitt15 jamiehewitt15 deleted the issue-327-optional-dashboard branch March 19, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants