Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escrow contract #894

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

v2.3.0-alpha.1

c3923e8
Select commit
Loading
Failed to load commit list.
Open

escrow contract #894

v2.3.0-alpha.1
c3923e8
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Slither succeeded Feb 3, 2025 in 7s

8 new alerts including 3 medium severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

  • 3 medium
  • 4 low

Other Alerts:

  • 1 warning

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 199 in contracts/escrow/Escrow.sol

See this annotation in the file changed.

Check notice on line 278 in contracts/escrow/Escrow.sol

See this annotation in the file changed.

Check warning on line 278 in contracts/escrow/Escrow.sol

See this annotation in the file changed.

Code scanning / Slither

Dangerous strict equalities Medium

Escrow.createLock(uint256,address,address,uint256,uint256) uses a dangerous strict equality:
- locks[i].payer == payer && locks[i].payee == msg.sender && locks[i].jobId == jobId

Check notice on line 339 in contracts/escrow/Escrow.sol

See this annotation in the file changed.

Code scanning / Slither

Block timestamp Low

Escrow.claimLock(uint256,address,address,uint256,bytes) uses timestamp for comparisons
Dangerous comparisons:
- tempLock.expiry < block.timestamp

Check notice on line 405 in contracts/escrow/Escrow.sol

See this annotation in the file changed.

Check warning on line 405 in contracts/escrow/Escrow.sol

See this annotation in the file changed.

Code scanning / Slither

Costly operations inside a loop Warning

Escrow.cancelExpiredLocks(uint256,address,address,address) has costly operations inside a loop:
- locks.pop()

Check warning on line 405 in contracts/escrow/Escrow.sol

See this annotation in the file changed.

Check warning on line 405 in contracts/escrow/Escrow.sol

See this annotation in the file changed.