Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on units #229

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

mhpob
Copy link
Contributor

@mhpob mhpob commented May 13, 2024

Remove dependency on units introduced in a50334a. The same outcome as units::drop_units can be done by coercing to a matrix. Addresses one part of #122.

Running the examples in make_transition3 with and without units::drop_units result in identical objects:

> identical(ex1, ex1_nounits)
[1] TRUE
> identical(ex2, ex2_nounits)
[1] TRUE
> identical(ex3, ex3_nounits)
[1] TRUE

This PR gets glatos down to 20 explicit dependencies, which clears the R CMD check dependency note:

Current R CMD check failure is due to a floating point issue on macOS which will be fixed with acceptance of #228

@mhpob mhpob marked this pull request as draft May 13, 2024 19:41
@mhpob mhpob marked this pull request as ready for review May 13, 2024 19:41
@chrisholbrook chrisholbrook merged commit d4d106f into ocean-tracking-network:dev Aug 14, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants