Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run test-vrl2csv on R-universe ("CRAN") #216

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

mhpob
Copy link
Contributor

@mhpob mhpob commented Feb 9, 2024

R-universe runs tests as CRAN and doesn't flag as on CI for some reason (@jdpye I was wrong in my note in #197). Adding skip_on_cran will skip these tests, which require vue.exe.

Test errors which prevent R-universe build on Windows and Mac:
https://github.com/r-universe/mhpob/actions/runs/7844599751/job/21407337477#step:5:1453
https://github.com/r-universe/mhpob/actions/runs/7844599751/job/21407336870#step:5:1373

Proof that skip_on_cran skips on R-universe (expect_snapshot is skipped on CRAN by default):
https://github.com/r-universe/mhpob/actions/runs/7844599751/job/21407337477#step:5:1435

@jdpye jdpye merged commit 9a7fd55 into ocean-tracking-network:dev Feb 9, 2024
0 of 5 checks passed
@mhpob mhpob deleted the patch-3 branch February 9, 2024 21:22
@mhpob mhpob restored the patch-3 branch February 9, 2024 21:31
@mhpob mhpob mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants