Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernized examples in animation functions, fixed data.table error in summarize_detections #192

Merged
merged 6 commits into from
Jan 5, 2024

Conversation

haydento
Copy link
Collaborator

@haydento haydento commented Jan 5, 2024

Updated examples in animation functions (not critical, original works as written, just trying to move from raster to terra), added ability to submit a terra::spatVector format as background map to detection_bubble_plot (not critical, works as is), and fixed summarize_detections (this one does impact usage of function) bug that reported "glatos_array" when summarize_detections was called with default values i.e.,

#get path to example detection file
det_file <- system.file("extdata", "walleye_detections.csv", package = "glatos")
det <- read_glatos_detections(det_file)
ds <- summarize_detections(det = det, location_col = "glatos_array", receiver_locs = NULL, animals = NULL, summ_type = "animal")

@jdpye
Copy link
Member

jdpye commented Jan 5, 2024

Big merge comin here! Looking through this while trying to sort out the auto-build. I'm going to have to drop GISTools from the dependencies, would this PR have a recommended replace for the one spot we use that package, over in detection_range_handout.Rmd ?

@jdpye jdpye changed the base branch from main to dev January 5, 2024 20:14
@jdpye
Copy link
Member

jdpye commented Jan 5, 2024

Chatted with @chrisholbrook , he suggested changing the base of this to dev and that cleaned up what was going on significantly.

@jdpye
Copy link
Member

jdpye commented Jan 5, 2024

looks like a code linter really had its way with a few of these files. Hope I picked the right side of things, the whole file was marked as the diff but nothing substantive outside of whitespace and the great_lakes_poly changes were apparent to me.

@jdpye jdpye mentioned this pull request Jan 5, 2024
@jdpye
Copy link
Member

jdpye commented Jan 5, 2024

I looked into the linting, it's the styler package that gets called via the Style GHA. It's using the 'tidyverse recommended style guide' so that's where it's coming from. Probably a benefit to us in the end to have this running and looking over our shoulders.

@jdpye jdpye merged commit ae1eba0 into dev Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants