Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "trust cache" repository option #5981

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AltGr
Copy link
Member

@AltGr AltGr commented May 29, 2024

No description provided.

@AltGr AltGr marked this pull request as draft May 29, 2024 16:46
@AltGr
Copy link
Member Author

AltGr commented May 29, 2024

This is an attempted quickfix for the automated repo cache at https://gitlab.ocamlpro.com/OCamlPro/opam-repository/-/tree/cached : the repository fetched from CI has git LFS handles for the cached files, but not the full files, so their hashes can't be recomputed.

@AltGr
Copy link
Member Author

AltGr commented May 29, 2024

(it worked)

@AltGr AltGr marked this pull request as ready for review May 29, 2024 17:26
@AltGr AltGr requested a review from rjbou June 26, 2024 13:18
@AltGr
Copy link
Member Author

AltGr commented Jan 22, 2025

The OCamlPro repo cache (https://gitlab.ocamlpro.com/OCamlPro/opam-repository/-/tree/cached) still needs this feature

@kit-ty-kate
Copy link
Member

Sorry for the lack of feedback. We had discussed it in a meeting a while back and forgot to write the conclusion here. I personally think having this environment variable available for everyone is too dangerous. I think having an argument limited to opam admin cache would be just fine although i'm not sure what's the best API to have for this, maybe just a new ?unsafe_trust_cache:bool argument to fetch_from_cache would be enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants