Don't ask confirmation when pinning a new package

Co-authored-by: R. Boujbel <[email protected]>
ocaml · Feb 4, 2025 · 9e214de · 9e214de
1 parent d2f2e6b
commit 9e214de
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/master_changes.md b/master_changes.md
@@ -47,6 +47,7 @@ users)
 ## Pin
   * [NEW] Make it so pin list display the current revision of a pinned repository in a new column [#6274 @desumn - fix #5533]
   * [BUG] Stop double pin of packages located in ./opam/opam [#6343 @kit-ty-kate - fix #6342]
+  * Don't ask confirmation when pinning an unknown package (absent from repositories) [#6309 @kit-ty-kate @rjbou - fix #3199]
 
 ## List
 

diff --git a/src/client/opamPinCommand.ml b/src/client/opamPinCommand.ml
@@ -491,12 +491,10 @@ and source_pin
       version, None
   in
 
-  if not (OpamPackage.has_name st.packages name) &&
-     not (OpamConsole.confirm
-            "Package %s does not exist, create as a %s package?"
-            (OpamPackage.Name.to_string name)
-            (OpamConsole.colorise `bold "NEW"))
-  then raise Aborted;
+  if not (OpamPackage.has_name st.packages name) then
+    OpamConsole.note "Package %s does not exist in opam repositories \
+                      registered in the current switch."
+      (OpamPackage.Name.to_string name);
 
   (match OpamStd.Option.map OpamFile.URL.url cur_urlf, target_url with
    | Some u, Some target when OpamUrl.(
-Original file line number
+Diff line change
@@ Expand Up / @@ -47,6 +47,7 @@ users) @@
     ## Pin
       * [NEW] Make it so pin list display the current revision of a pinned repository in a new column [#6274 @desumn - fix #5533]
       * [BUG] Stop double pin of packages located in ./opam/opam [#6343 @kit-ty-kate - fix #6342]
+      * Don't ask confirmation when pinning an unknown package (absent from repositories) [#6309 @kit-ty-kate @rjbou - fix #3199]
     ## List
@@ Expand Down @@