Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ocaml-version constraint for ocp-index 1.0.0 #6602

Merged
merged 1 commit into from
May 23, 2016
Merged

Conversation

samoht
Copy link
Member

@samoht samoht commented May 23, 2016

In 1.2.0 this was saying:

RROR] available is not a valid variable.
[WARNING] Invalid variable available in filter

And the constraint was discarded for opam 1.2.2

In 1.2.0 this was saying:

```
RROR] available is not a valid variable.
[WARNING] Invalid variable available in filter
```

And the constraint was discarded for opam 1.2.2
@samoht
Copy link
Member Author

samoht commented May 23, 2016

/cc @lefessan see #6581 (comment)

@camelus
Copy link
Contributor

camelus commented May 23, 2016

❌ opam-lint errors 6ebc4c9
  • ocp-index.1.0.0 has errors:
    • error 24: Field 'maintainer' has the old default value
    • error 25: Missing field 'authors'
    • warning 26: No field 'install', but a field 'remove': install instructions probably part of 'build'. Use the 'install' field
      or a .install file
    • warning 36: Missing field 'bug-reports'

@samoht samoht merged commit 5945216 into ocaml:master May 23, 2016
@dsheets
Copy link
Member

dsheets commented May 24, 2016

I think this would have been be caught if ocaml-opam/Camelus#8 were implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants