Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Typed_holes to Merlin #1451

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Move Typed_holes to Merlin #1451

merged 2 commits into from
Jan 31, 2025

Conversation

liam923
Copy link
Contributor

@liam923 liam923 commented Jan 17, 2025 •
edited
Loading

This is a complement to ocaml/merlin#1888, which renames Texp_hole and Tmod_hole to Texp_typed_hole and Tmod_typed_hole.

@liam923 liam923 changed the title Rename holes Move Typed_holes to Merlin Jan 17, 2025
@liam923 liam923 marked this pull request as ready for review January 17, 2025 17:42
@liam923 liam923 mentioned this pull request Jan 17, 2025
Merged
voodoos
voodoos approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@voodoos voodoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will merge once the CI passes.

@voodoos voodoos merged commit 0271918 into ocaml:master Jan 31, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voodoos voodoos voodoos approved these changes

Assignees
No one assigned
Labels
no changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liam923 @voodoos