refactor: allow config values to be defined anywhere #9388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/refactor__allow_config_values_to_be_defined_anywhere
branch
from
fbcd6d4 to
66483ad
Compare
rgrinberg
force-pushed
the
ps/rr/refactor__allow_config_values_to_be_defined_anywhere
branch
from
66483ad to
1226100
Compare
Alizter
reviewed
Dec 11, 2023
snowleopard
approved these changes
Dec 18, 2023
Expose a [Config.make] function to allow settings to be defined anywhere. Move dune rules specific configuration to [Dune_rules] Signed-off-by: Rudi Grinberg <[email protected]> <!-- ps-id: a74081fc-15c8-4c07-8397-897ff88e104c -->
rgrinberg
force-pushed
the
ps/rr/refactor__allow_config_values_to_be_defined_anywhere
branch
from
1226100 to
b32cb16
Compare
rgrinberg
deleted the
ps/rr/refactor__allow_config_values_to_be_defined_anywhere
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose a [Config.make] function to allow settings to be defined
anywhere.
Move dune rules specific configuration to [Dune_rules].
@snowleopard this should reduce some potential for syncing by allowing internal/external dune to keep private config options outside of the main module.