chore(pkg): leave CR regarding substitution (#9409)

Signed-off-by: Rudi Grinberg <[email protected]>
ocaml · Dec 7, 2023 · c654613 · c654613
1 parent 2eb12b9
commit c654613
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/src/dune_pkg/opam_solver.ml b/src/dune_pkg/opam_solver.ml
@@ -214,6 +214,7 @@ let is_valid_global_variable_name = function
   | _ -> true
 ;;
 
+(* CR-rgrinberg: we need this validation in substitution actions as well *)
 let is_valid_package_variable_name = function
   | "hash" | "build-id" | "misc" | "opam-version" | "depends" | "build" | "opamfile" ->
     false