Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Use proper URL fragments ("#tab=…", not "#tab%3D…") #557

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Jul 27, 2023

  • Kind: bugfix (workaround)

Description

Fix #539 while the upstream patch ocsigen/js_of_ocaml#1497 is not used.

Checklist

Note to maintainers

  • Read this wiki page.
  • Make sure the PR has a milestone.
  • Assign yourself before merging.
  • Either do a regular merge:
    • for PRs containing several commits following conventional-commits,
    • or for PRs containing 1 commit shared with a later PR (to preserve the SHA1)
  • Or do a squash-merge:
    • for PRs containing only 1 commit (not shared with a later PR),
    • or for PRs containing several commits that need not be kept in the history;
    • Update the commit message header with a conventional-commit type,
    • Add a footer Close #… if a related issue exists.

@erikmd erikmd added this to the learn-ocaml 1.0.0 milestone Aug 11, 2023
@yurug
Copy link
Collaborator

yurug commented Aug 18, 2023

LGTM.

@yurug yurug merged commit 7f2b6cf into ocaml-sf:master Aug 18, 2023
@erikmd erikmd deleted the fix-set-fragment branch August 18, 2023 12:25
@erikmd
Copy link
Member Author

erikmd commented Aug 18, 2023

@yurug You forgot to assign yourself before merging 🙃 ; fixed just now.

Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: rewrite URLs so that %3D chars are rendered as =
2 participants