Convert winapi transmute to internal union handling #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obv-mikhail
approved these changes
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64
In general, Rust 1.64 added a forced panic to
std::mem::transmute_copyif the destination struct is larger than the source, as it is technically UB. InputBot was using this mechanism to convert keyboard or mouse input to the INPUT_u union, which ALWAYS triggers the panic.This fixes everything as far as I can tell, BUT it is the first unsafe code I've ever written, so please please please don't merge unless someone else is also confident it doesn't explode! This does seem like the intended method the winapi crate wants people to use, though