Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow band and colour images #3

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zemogle
Copy link
Contributor

@zemogle zemogle commented Feb 22, 2024

I've updated the colour composite framework to include the narrowband filters for making colour images.

I've also added a planet option. This is different to the rest of the thumbnail code in that it always generates images of the same size 600 x 600 centred around a planet. The aim is to provide more reasonable scaling for planets which mostly lose their features when using fits_to_jpg. It also balances the colours better in a colour image.

I've added extra test coverage.

I will update the portal code to check for planets on the request (probably using the scheme==JPL_MAJOR_PLANET)

Copy link
Member

@jnation3406 jnation3406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convert_to_planet_jpg and then planet_image_to_jpg methods should probably take in the params as well, and should respect the set values for width/height/quality at least. You can probably skip supporting label_text, and it already is supporting color.

Otherwise it looks good, but with the caveat that we call this from the archive to show thumbnails within the archive client UI, and I don't think we have any way of knowing if the image is of a planet from the data in the archive... unless its stored in the fits header somewhere? The target scheme being minor planet is in the request language for the observation, but not stored in the archives Frames model, so unless its in the fits header that might make knowing when to get planet jpegs harder from the archive client.

@zemogle
Copy link
Contributor Author

zemogle commented Apr 12, 2024

This got pushed down my list. Thanks for the suggestions @jnation3406 I've added your suggestions for parsing the params and respecting the height and width, adding test coverage to check the output file dimensions.

I completely understand your caveat for thumbnails in the archive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants