Fix k8s permissions #133
Merged
Fix k8s permissions #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipgough
approved these changes
May 16, 2024
christopherzli
pushed a commit
to christopherzli/thanos-receive-controller
that referenced
this pull request
Aug 16, 2024
* Fix k8s permissions * fix ci * fix ci
christopherzli
added a commit
to christopherzli/thanos-receive-controller
that referenced
this pull request
Aug 16, 2024
This reverts commit e545b83.
christopherzli
added a commit
to christopherzli/thanos-receive-controller
that referenced
this pull request
Aug 16, 2024
This reverts commit e545b83.
christopherzli
added a commit
to christopherzli/thanos-receive-controller
that referenced
this pull request
Aug 16, 2024
This reverts commit e545b83.
christopherzli
added a commit
to christopherzli/thanos-receive-controller
that referenced
this pull request
Aug 16, 2024
This reverts commit e545b83.
christopherzli
added a commit
to databricks/thanos-receive-controller
that referenced
this pull request
Aug 19, 2024
* support az aware hashring and multiple sts in one hashring (observatorium#129) * support az aware hashring * Update receive-controller.json * support multiple statefulsets in 1 hashring * add more logs * style * fix lint issue * debug * return when encountering error * remove whitespace * Fix k8s permissions (observatorium#133) * Fix k8s permissions * fix ci * fix ci * sync * add pantheon migration state * Revert "Fix k8s permissions (observatorium#133)" This reverts commit e545b83. --------- Co-authored-by: Alec Rajeev <[email protected]>
jnyi
pushed a commit
to databricks/thanos-receive-controller
that referenced
this pull request
Oct 2, 2024
* support az aware hashring and multiple sts in one hashring (observatorium#129) * support az aware hashring * Update receive-controller.json * support multiple statefulsets in 1 hashring * add more logs * style * fix lint issue * debug * return when encountering error * remove whitespace * Fix k8s permissions (observatorium#133) * Fix k8s permissions * fix ci * fix ci * sync * add pantheon migration state * Revert "Fix k8s permissions (observatorium#133)" This reverts commit e545b83. --------- Co-authored-by: Alec Rajeev <[email protected]> Signed-off-by: Yi Jin <[email protected]>
jnyi
pushed a commit
to databricks/thanos-receive-controller
that referenced
this pull request
Oct 2, 2024
* support az aware hashring and multiple sts in one hashring (observatorium#129) * support az aware hashring * Update receive-controller.json * support multiple statefulsets in 1 hashring * add more logs * style * fix lint issue * debug * return when encountering error * remove whitespace * Fix k8s permissions (observatorium#133) * Fix k8s permissions * fix ci * fix ci * sync * add pantheon migration state * Revert "Fix k8s permissions (observatorium#133)" This reverts commit e545b83. --------- Co-authored-by: Alec Rajeev <[email protected]> Signed-off-by: Yi Jin <[email protected]>
jnyi
pushed a commit
to databricks/thanos-receive-controller
that referenced
this pull request
Oct 2, 2024
* support az aware hashring and multiple sts in one hashring (observatorium#129) * support az aware hashring * Update receive-controller.json * support multiple statefulsets in 1 hashring * add more logs * style * fix lint issue * debug * return when encountering error * remove whitespace * Fix k8s permissions (observatorium#133) * Fix k8s permissions * fix ci * fix ci * sync * add pantheon migration state * Revert "Fix k8s permissions (observatorium#133)" This reverts commit e545b83. --------- Co-authored-by: Alec Rajeev <[email protected]> Signed-off-by: Yi Jin <[email protected]>
jnyi
pushed a commit
to databricks/thanos-receive-controller
that referenced
this pull request
Oct 2, 2024
* support az aware hashring and multiple sts in one hashring (observatorium#129) * support az aware hashring * Update receive-controller.json * support multiple statefulsets in 1 hashring * add more logs * style * fix lint issue * debug * return when encountering error * remove whitespace * Fix k8s permissions (observatorium#133) * Fix k8s permissions * fix ci * fix ci * sync * add pantheon migration state * Revert "Fix k8s permissions (observatorium#133)" This reverts commit e545b83. --------- Co-authored-by: Alec Rajeev <[email protected]> Signed-off-by: Yi Jin <[email protected]>
jnyi
pushed a commit
to databricks/thanos-receive-controller
that referenced
this pull request
Oct 3, 2024
* support az aware hashring and multiple sts in one hashring (observatorium#129) * support az aware hashring * Update receive-controller.json * support multiple statefulsets in 1 hashring * add more logs * style * fix lint issue * debug * return when encountering error * remove whitespace * Fix k8s permissions (observatorium#133) * Fix k8s permissions * fix ci * fix ci * sync * add pantheon migration state * Revert "Fix k8s permissions (observatorium#133)" This reverts commit e545b83. --------- Co-authored-by: Alec Rajeev <[email protected]> Signed-off-by: Yi Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature that annotates the pod with the timestamp when the hashring configmap updates will list the pods. This list pods permission should be added to the role permissions in the example manifests.
https://github.com/observatorium/thanos-receive-controller/blob/main/main.go#L748
https://github.com/observatorium/thanos-receive-controller/blob/main/examples/manifests/role.yaml#L27
Fixes: #132