Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Inputs.file #459

Closed
wants to merge 1 commit into from
Closed

add Inputs.file #459

wants to merge 1 commit into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Jan 9, 2024

closes #143

to test:

# Inputs.file

```js
const f = view(Inputs.file())
```

```js
f.sqlite()
```

```js
f.image()
```

@Fil Fil requested review from mbostock and allisonhorst January 9, 2024 12:58
@Fil
Copy link
Contributor Author

Fil commented Jan 9, 2024

A documentation/example could be a "data app" that allows the user to attach a file to a page and do some data processing (on an image, or an an excel file?)

Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fix the built-in Inputs, but it doesn’t fix it when you import Inputs explicitly (which you have to do from an ES module) like so:

import * as Inputs from "npm:@observablehq/inputs";

So, we’ll either need to fix the resolution of npm:@observablehq/inputs to get a wrapper library with the fix, or we’ll need to publish a fix to Observable Inputs itself. I was expecting to do the latter given that we also need to fix the stylesheet #29.

@Fil
Copy link
Contributor Author

Fil commented Jan 9, 2024

Thanks, now I see the problem with this approach.

@Fil Fil closed this Jan 9, 2024
@Fil Fil deleted the fil/inputsfile branch January 9, 2024 17:17
@Fil
Copy link
Contributor Author

Fil commented Jan 9, 2024

superseded by #469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inputs.file is not a function
2 participants