-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve npm imports #303
Merged
Merged
resolve npm imports #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
mbostock/resolve-npm-import
branch
from
December 2, 2023 23:29
84ebb50
to
95cfd37
Compare
Fil
approved these changes
Dec 4, 2023
Co-authored-by: Philippe Rivière <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the exact version of any imported npm module at build time. This improves performance by allowing cache-control immutable for imported modules and by preventing duplicate loads of the same library. (For example, the
npm:d3-dsv
needed forfile.csv()
is now the same as the one you get if you importnpm:d3
.) It also improves security and stability by ensuring that new releases won’t break your existing project, while still automatically giving you the latest version at build time. We could further improve security using subresource integrity.I’ve staged this as a PR on top of #294 because it depends on some upstream changes, but I also didn’t want to add yet more new functionality to that already-large PR!
TODO
and Observable Inputs)PendingTranspile
complexity somehowFixes #135. We can fix the Inputs stylesheet after #29.