Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inputs.file is not a function #143

Closed
mbostock opened this issue Nov 10, 2023 · 2 comments · Fixed by #469
Closed

Inputs.file is not a function #143

mbostock opened this issue Nov 10, 2023 · 2 comments · Fixed by #469
Assignees
@mbostock
Labels
bug Something isn’t working
Milestone
Early access

Comments

@mbostock
Copy link
Member

mbostock commented Nov 10, 2023 •
edited
Loading

Due to the caveat described here:

https://github.com/observablehq/inputs#inputsfileoptions

Related #29.
@mbostock mbostock added the bug Something isn’t working label Nov 10, 2023
@mbostock mbostock added this to the Early access milestone Nov 13, 2023
@mbostock mbostock mentioned this issue Nov 30, 2023
Closed
@mbostock
Copy link
Member Author

mbostock commented Dec 6, 2023

This is much easier to solve with #294!

@mbostock
Copy link
Member Author

More specifically: the new @observablehq/stdlib does not depend on @observablehq/inputs because the concept of recommend libraries has been pulled out of the standard library. And hence we can change @observablehq/inputs to depend on @observablehq/stdlib and just have it work. But this will be a breaking change along with the necessary changes to bundling and stylesheets described in #29.

Fil added a commit that referenced this issue Jan 9, 2024
@Fil
add Inputs.file
1a0929f 
closes #143
@Fil Fil mentioned this issue Jan 9, 2024
Closed
@Fil Fil assigned Fil and unassigned Fil Jan 9, 2024
@mbostock mbostock mentioned this issue Jan 9, 2024
Merged
@mbostock mbostock self-assigned this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbostock mbostock

Labels
bug Something isn’t working
Projects
None yet
Milestone
Early access
Development

Successfully merging a pull request may close this issue.

fix Inputs.file observablehq/framework
add Inputs.file observablehq/framework
2 participants
@Fil @mbostock