Remove basic.owl and metazoan-view.owl #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom release product 'basic.owl' is, by construction, exactly the same as the standard product 'uberon-basic.owl' and is, therefore, pointless and be removed.
Update all goals that depend on the basic.owl product to make them depend on the uberon-basic.owl (which is the same thing) instead.
What we pretend to be a 'metazoan subset' is actually uberon-basic, so let's not waste time and disk space creating a copy for nothing. If people need a metazoan-view.owl file, we can add a PURL redirection to uberon-basic.owl.
matentzn
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Good move.
I made the relevant change to the PURL system: OBOFoundry/purl.obolibrary.org#977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes two release products that are completely redundant since they are identical to another release product:
basic.owl: exactly identical touberon-basic.owlexcept that is has a different ontology IRI;metazoan-view.owl: exactly identical tobasic.owl(and therefore touberon-basic.owl).There’s no need to waste time building those products and waste space hosting them. If some some pipelines out there are dependent on those files, they should be updated to use
uberon-basic.owlinstead. And if these are old pipelines that for some reason can’t be updated, then we should just have one more redirection in Uberon’s PURL configuration.Download statistics for the Uberon releases suggest the
metazoan-view.owlfile at least is never downloaded by anyone.closes #3013