Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck query publickey #510

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Healthcheck query publickey #510

merged 2 commits into from
Jan 22, 2024

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jan 22, 2024

Healthcheck now also periodically tests querying public keys if the Oasis RPC API is enabled (which tests keymanager node access).

Renames metrics prefix from oasis_oasis_ to oasis_ (caused due the emerald-web3-gateway -> oasis_web3_gateway rename).

Fixes the oasis_ RPC endpoint to only be exposed if configured via ExposeOasisRPCs. Because the Public and Version fields in ethRPC.API were deprecated and not used, the endpoint was always exposed.

@ptrus ptrus requested a review from kostko as a code owner January 22, 2024 10:21
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (1211f06) 62.42% compared to head (41dc50a) 61.08%.

❗ Current head 41dc50a differs from pull request most recent head 4fe0847. Consider uploading reports for the commit 4fe0847 to get more accurate results

Files Patch % Lines
rpc/oasis/health.go 0.00% 32 Missing ⚠️
rpc/apis.go 46.66% 7 Missing and 1 partial ⚠️
rpc/oasis/api.go 0.00% 6 Missing ⚠️
server/json_rpc.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
- Coverage   62.42%   61.08%   -1.35%     
==========================================
  Files          37       38       +1     
  Lines        3931     3962      +31     
==========================================
- Hits         2454     2420      -34     
- Misses       1272     1337      +65     
  Partials      205      205              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptrus ptrus force-pushed the ptrus/feature/oasis-healthcheck branch from b01221c to 41dc50a Compare January 22, 2024 10:29
rpc/oasis/api.go Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/oasis-healthcheck branch from 41dc50a to a4fa713 Compare January 22, 2024 10:39
@ptrus ptrus force-pushed the ptrus/feature/oasis-healthcheck branch from a4fa713 to 4fe0847 Compare January 22, 2024 10:45
@ptrus ptrus enabled auto-merge January 22, 2024 10:45
@ptrus ptrus merged commit fce4470 into main Jan 22, 2024
5 of 6 checks passed
@ptrus ptrus deleted the ptrus/feature/oasis-healthcheck branch January 22, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants