Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-sdk: remove compressed format requirement from ECDSA precompiles #1570

Merged
merged 1 commit into from
Nov 27, 2023
Merged

runtime-sdk: remove compressed format requirement from ECDSA precompiles #1570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions runtime-sdk/src/crypto/signature/secp256k1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,9 @@

/// Construct a public key from a slice of bytes.
pub fn from_bytes(bytes: &[u8]) -> Result<Self, Error> {
let ep = k256::EncodedPoint::from_bytes(bytes).map_err(|_| Error::MalformedPublicKey)?;
if !ep.is_compressed() {
return Err(Error::MalformedPublicKey);
}
Ok(PublicKey(ep))
k256::EncodedPoint::from_bytes(bytes)
.map_err(|_| Error::MalformedPublicKey)

Check warning on line 40 in runtime-sdk/src/crypto/signature/secp256k1.rs

View check run for this annotation

Codecov / codecov/patch

runtime-sdk/src/crypto/signature/secp256k1.rs#L40 

Added line #L40 was not covered by tests
.map(PublicKey)
}

/// Verify a signature.
Expand Down
8 changes: 3 additions & 5 deletions runtime-sdk/src/crypto/signature/secp256r1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,9 @@

/// Construct a public key from a slice of bytes.
pub fn from_bytes(bytes: &[u8]) -> Result<Self, Error> {
let ep = p256::EncodedPoint::from_bytes(bytes).map_err(|_| Error::MalformedPublicKey)?;
if !ep.is_compressed() {
return Err(Error::MalformedPublicKey);
}
Ok(PublicKey(ep))
p256::EncodedPoint::from_bytes(bytes)
.map_err(|_| Error::MalformedPublicKey)

Check warning on line 27 in runtime-sdk/src/crypto/signature/secp256r1.rs

View check run for this annotation

Codecov / codecov/patch

runtime-sdk/src/crypto/signature/secp256r1.rs#L27 

Added line #L27 was not covered by tests
.map(PublicKey)
}

/// Verify a signature.
Expand Down
8 changes: 3 additions & 5 deletions runtime-sdk/src/crypto/signature/secp384r1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,9 @@

/// Construct a public key from a slice of bytes.
pub fn from_bytes(bytes: &[u8]) -> Result<Self, Error> {
let ep = p384::EncodedPoint::from_bytes(bytes).map_err(|_| Error::MalformedPublicKey)?;
if !ep.is_compressed() {
return Err(Error::MalformedPublicKey);
}
Ok(PublicKey(ep))
p384::EncodedPoint::from_bytes(bytes)
.map_err(|_| Error::MalformedPublicKey)

Check warning on line 26 in runtime-sdk/src/crypto/signature/secp384r1.rs

View check run for this annotation

Codecov / codecov/patch

runtime-sdk/src/crypto/signature/secp384r1.rs#L26 

Added line #L26 was not covered by tests
.map(PublicKey)
}

/// Verify a signature.
Expand Down
Loading