go/runtime/client: Add the GetUnconfirmedTransactions method #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
abukosek
force-pushed
the
andrej/feature/runtime-get-unconfirmed-tx-rpc
branch
2 times, most recently
from
a73306d to
965826c
Compare
abukosek
requested review from
kostko,
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
kostko
requested changes
Mar 8, 2024
abukosek
force-pushed
the
andrej/feature/runtime-get-unconfirmed-tx-rpc
branch
from
965826c to
88ccf5c
Compare
kostko
reviewed
Mar 11, 2024
abukosek
force-pushed
the
andrej/feature/runtime-get-unconfirmed-tx-rpc
branch
2 times, most recently
from
dd42b96 to
cccbd78
Compare
kostko
reviewed
Mar 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5589 +/- ##
==========================================
+ Coverage 66.00% 66.02% +0.01%
==========================================
Files 588 588
Lines 60085 60132 +47
==========================================
+ Hits 39662 39702 +40
+ Misses 15790 15782 -8
- Partials 4633 4648 +15 ☔ View full report in Codecov by Sentry. |
abukosek
force-pushed
the
andrej/feature/runtime-get-unconfirmed-tx-rpc
branch
2 times, most recently
from
0de92cd to
73d7005
Compare
kostko
reviewed
Mar 11, 2024
abukosek
force-pushed
the
andrej/feature/runtime-get-unconfirmed-tx-rpc
branch
from
73d7005 to
d019e8e
Compare
peternose
reviewed
Mar 11, 2024
Similarly to GetUnconfirmedTransactions in the consensus API, this new method returns the currently pending runtime transactions from the runtime transaction pool.
abukosek
force-pushed
the
andrej/feature/runtime-get-unconfirmed-tx-rpc
branch
from
d019e8e to
e901e77
Compare
peternose
approved these changes
Mar 15, 2024
kostko
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to
GetUnconfirmedTransactionsin the consensus API, this new method returns the currently pending runtime transactions from the runtime transaction pool.