Merge upgrade and preupgrade script, add sync script #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 2 1 -1
Lines 311 164 -147
==========================================
- Hits 311 164 -147 ☔ View full report in Codecov by Sentry. |
|
Tested locally on vagrant machine, along with RHC worker. Sync script work well, and preupgrade/upgrade too. |
Monnte
force-pushed
the
merge-scripts
branch
2 times, most recently
from
97cb2b9 to
5d4188f
Compare
andywaltlova
requested changes
Jan 22, 2024
There was a problem hiding this comment.
Looks good, please update the sync script to work with the pre-commit as we disscused in #6 , the one mafilip created is in scripts folder now. Thank you!
|
Done. 👍 |
andywaltlova
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OAMG-10335