Add alert and error fields to output (same as for pre-conversion) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andywaltlova
commented
Nov 16, 2023
•
andywaltlova
commented
- Add alert and error fields to output (same as for pre-conversion in oamg/convert2rhel-insights-tasks@cff4873)
- Updated tests because of slight refactor
- Fix Process error outside of try block
Updated tests because of slight refactor Fix Process error outside of try block Signed-off-by: Andrea Waltlova <[email protected]>
Signed-off-by: Andrea Waltlova <[email protected]>
andywaltlova
force-pushed
the
update-preupgrade-task-reporting
branch
from
bc13f08 to
6e53a72
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 135 145 +10
=========================================
+ Hits 135 145 +10 ☔ View full report in Codecov by Sentry. |
Monnte
reviewed
Nov 16, 2023
Signed-off-by: Andrea Waltlova <[email protected]>
andywaltlova
force-pushed
the
update-preupgrade-task-reporting
branch
from
f7f4ab5 to
edad91c
Compare
Monnte
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.